diff --git a/webui/group-add.php b/webui/group-add.php index 3c54bf90d7efe209a0993c32387baa611b8f664f..c34bd352a9db3f7981748e1edb609111e700eca3 100644 --- a/webui/group-add.php +++ b/webui/group-add.php @@ -92,30 +92,19 @@ if (isset($_POST['frmaction']) && $_POST['frmaction'] == "add") { $_POST['group_disabled'], $_POST['group_comment'], )); - if ($res) { - + if ($res !== FALSE) { ?> - <div class="notice">Group created</div> - <?php - } else { - ?> - <div class="warning">Failed to create group</div> <div class="warning"><?php print_r($stmt->errorInfo()) ?></div> - <?php - } } else { - ?> - <div class="warning">Group name cannot be empty!</div> - <?php } diff --git a/webui/group-delete.php b/webui/group-delete.php index 38ce76956fa06aeabacc6bd8eb92c8c2d9dddb43..b4b70e3849274d8749d6b38932168e6e37be4326 100644 --- a/webui/group-delete.php +++ b/webui/group-delete.php @@ -79,37 +79,73 @@ if (isset($_POST['frmaction']) && $_POST['frmaction'] == "delete") { $db->beginTransaction(); - $res = $db->exec("DELETE FROM ${DB_TABLE_PREFIX}users_to_groups WHERE GroupID = ".$db->quote($_POST['group_id'])); + $res = $db->exec(" + DELETE FROM + ${DB_TABLE_PREFIX}users_to_groups + WHERE + GroupID = ".$db->quote($_POST['group_id'])." + "); if ($res !== FALSE) { - $res = $db->exec("DELETE FROM ${DB_TABLE_PREFIX}group_attributes WHERE GroupID = ".$db->quote($_POST['group_id'])); +?> + <div class="notice">User to group mappings removed</div> +<?php + } else { +?> + <div class="warning">Error removing user mappings from group</div> + <div class="warning"><?php print_r($db->errorInfo()) ?></div> +<?php + } + + if ($res !== FALSE) { + + $res = $db->exec(" + DELETE FROM + ${DB_TABLE_PREFIX}group_attributes + WHERE + GroupID = ".$db->quote($_POST['group_id'])." + "); + if ($res !== FALSE) { +?> + <div class="notice">Group group attributes removed</div> +<?php + } else { +?> + <div class="warning">Error removing group attributes</div> + <div class="warning"><?php print_r($db->errorInfo()) ?></div> +<?php + } + } + + + if ($res !== FALSE) { $res = $db->exec("DELETE FROM ${DB_TABLE_PREFIX}groups WHERE ID = ".$db->quote($_POST['group_id'])); + if ($res !== FALSE) { ?> <div class="notice">Group deleted</div> <?php - $db->commit(); } else { ?> <div class="warning">Error deleting group</div> <div class="warning"><?php print_r($db->errorInfo()) ?></div> <?php - $db->rollback(); } - } else { + } + + # Check if all is ok, if so, we can commit, else must rollback + if ($res !== FALSE) { + $db->commit(); ?> - <div class="warning">Error deleting group</div> - <div class="warning"><?php print_r($db->errorInfo()) ?></div> + <div class="notice">Changes comitted.</div> <?php - $db->rollback(); - } } else { + $db->rollback(); ?> - <div class="warning">Error deleting group</div> - <div class="warning"><?php print_r($db->errorInfo()) ?></div> + <div class="notice">Changes reverted.</div> <?php - $db->rollback(); } + } else { ?> <div class="notice">Group not deleted, aborted by user</div>