diff --git a/webgui/include/ajax/functions/AdminGroupAttributes.php b/webgui/include/ajax/functions/AdminGroupAttributes.php index ca2b05dfa0f72478b110d169782095b562cb7f3d..0a6d710b0846b5f83fb4a7494c93c33e110219e6 100644 --- a/webgui/include/ajax/functions/AdminGroupAttributes.php +++ b/webgui/include/ajax/functions/AdminGroupAttributes.php @@ -17,7 +17,8 @@ function addAdminGroupAttribute($params) { $params[0]['Disabled']) ); - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } @@ -28,7 +29,9 @@ function addAdminGroupAttribute($params) { function removeAdminGroupAttribute($params) { $res = DBDo("DELETE FROM group_attributes WHERE ID = ?",array($params[0])); - if (!is_numeric($res)) { + + # Return result + if (is_bool($res)) { return $res; } @@ -46,7 +49,8 @@ function updateAdminGroupAttribute($params) { $params[0]['ID']) ); - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminGroupMembers.php b/webgui/include/ajax/functions/AdminGroupMembers.php index f848c126ed959129ff94861564b7396d4b8676d5..18809a8218e9867f498bc386d4212fc7e589ce47 100644 --- a/webgui/include/ajax/functions/AdminGroupMembers.php +++ b/webgui/include/ajax/functions/AdminGroupMembers.php @@ -6,7 +6,9 @@ include_once("include/db.php"); function removeAdminGroupMember($params) { $res = DBDo("DELETE FROM users_to_groups WHERE ID = ?",array($params[0])); - if (!is_numeric($res)) { + + # Return result + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminGroups.php b/webgui/include/ajax/functions/AdminGroups.php index c7711d2c59714e1ab81b7db87e14d34ae9fa99f3..ce66856f0005662024280c98ab943376d42ec2e2 100644 --- a/webgui/include/ajax/functions/AdminGroups.php +++ b/webgui/include/ajax/functions/AdminGroups.php @@ -88,7 +88,7 @@ function removeAdminGroup($params) { } # Commit and return if successful - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; # Else rollback database @@ -105,8 +105,8 @@ function createAdminGroup($params) { # Perform query $res = DBDo("INSERT INTO groups (Name) VALUES (?)",array($params[0]['Name'])); - # Return error if failed - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } @@ -119,8 +119,8 @@ function updateAdminGroup($params) { # Perform query $res = DBDo("UPDATE groups SET Name = ? WHERE ID = ?",array($params[0]['Name'],$params[0]['ID'])); - # Return error if failed - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminRealmAttributes.php b/webgui/include/ajax/functions/AdminRealmAttributes.php index bd97b2ccb15a3a7c1b1029dd974f201f319bb55d..74669a566b9470b46d6c3b31545adb602932ed6e 100644 --- a/webgui/include/ajax/functions/AdminRealmAttributes.php +++ b/webgui/include/ajax/functions/AdminRealmAttributes.php @@ -18,8 +18,8 @@ function addAdminRealmAttribute($params) { $params[0]['Disabled']) ); - # Return error if failed - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } @@ -32,8 +32,8 @@ function removeAdminRealmAttribute($params) { # Perform query $res = DBDo("DELETE FROM realm_attributes WHERE ID = ?",array($params[0])); - # Return error if failed - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } @@ -52,8 +52,8 @@ function updateAdminRealmAttribute($params) { $params[0]['ID']) ); - # Return error if failed - if (!is_numeric($res)) { + # Return result + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminRealms.php b/webgui/include/ajax/functions/AdminRealms.php index 2912c6951d28932468181a98605d4c80e81727a8..774b66283e4641fc33bab4ace581810e8735d5f9 100644 --- a/webgui/include/ajax/functions/AdminRealms.php +++ b/webgui/include/ajax/functions/AdminRealms.php @@ -77,7 +77,7 @@ function removeAdminRealm($params) { } # Commit and return if successful - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; # Else rollback database @@ -95,7 +95,7 @@ function createAdminRealm($params) { $res = DBDo("INSERT INTO realms (Name) VALUES (?)",array($params[0]['Name'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -109,7 +109,7 @@ function updateAdminRealm($params) { $res = DBDo("UPDATE realms SET Name = ? WHERE ID = ?",array($params[0]['Name'],$params[0]['ID'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminUserAttributes.php b/webgui/include/ajax/functions/AdminUserAttributes.php index 47d1834960634535fd1d376ad5a49d1afece3a15..cb6e041f6e3e7225fbca6a5798482732e4a09922 100644 --- a/webgui/include/ajax/functions/AdminUserAttributes.php +++ b/webgui/include/ajax/functions/AdminUserAttributes.php @@ -19,7 +19,7 @@ function addAdminUserAttribute($params) { ); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -33,7 +33,7 @@ function removeAdminUserAttribute($params) { $res = DBDo("DELETE FROM user_attributes WHERE ID = ?",array($params[0])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -53,7 +53,7 @@ function updateAdminUserAttribute($params) { ); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminUserGroups.php b/webgui/include/ajax/functions/AdminUserGroups.php index 3a9a3499f3ace39a1ab2a0bd23554b385cdb3fa6..a19c636aeb9baee1a1e87be69127744cedba4d2d 100644 --- a/webgui/include/ajax/functions/AdminUserGroups.php +++ b/webgui/include/ajax/functions/AdminUserGroups.php @@ -10,7 +10,7 @@ function addAdminUserGroup($params) { $res = DBDo("INSERT INTO users_to_groups (UserID,GroupID) VALUES (?,?)",array($params[0]['UserID'],$params[0]['GroupID'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -24,7 +24,7 @@ function removeAdminUserGroup($params) { $res = DBDo("DELETE FROM users_to_groups WHERE ID = ?",array($params[0])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminUserTopups.php b/webgui/include/ajax/functions/AdminUserTopups.php index a22ea0b430bb2f16064c7e6f1f62677c93b79a94..479d82d8dcce2b27e904a924cb41b8f86b58ac2c 100644 --- a/webgui/include/ajax/functions/AdminUserTopups.php +++ b/webgui/include/ajax/functions/AdminUserTopups.php @@ -16,7 +16,7 @@ function createAdminUserTopup($params) { ); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -36,7 +36,7 @@ function updateAdminUserTopup($params) { ); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -50,7 +50,7 @@ function removeAdminUserTopup($params) { $res = DBDo("DELETE FROM topups WHERE ID = ?",array($params[0])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/AdminUsers.php b/webgui/include/ajax/functions/AdminUsers.php index 97563bf7aaca57a7ab9e4df568fce98af3d93e1a..8b273c3bc51cfd2bab7c1671d02e8a74ebd6bb36 100644 --- a/webgui/include/ajax/functions/AdminUsers.php +++ b/webgui/include/ajax/functions/AdminUsers.php @@ -103,9 +103,10 @@ function removeAdminUser($params) { while ($row = $res->fetchObject()) { array_push($topupList,$row->topupid); } + $res = TRUE; } - if ($res !== FALSE && sizeof($topupList) > 0) { + if (sizeof($topupList) > 0 && $res !== FALSE) { # Remove topup summaries foreach ($topupList as $id) { if ($res !== FALSE) { @@ -132,7 +133,7 @@ function removeAdminUser($params) { } # Commit and return if successful - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; # Else rollback database @@ -150,7 +151,7 @@ function createAdminUser($params) { $res = DBDo("INSERT INTO users (Username) VALUES (?)",array($params[0]['Username'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -164,7 +165,7 @@ function updateAdminUser($params) { $res = DBDo("UPDATE users SET Username = ? WHERE ID = ?",array($params[0]['Username'],$params[0]['ID'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/WiSPLocationMembers.php b/webgui/include/ajax/functions/WiSPLocationMembers.php index b9f69d1f46bbccaf86a9a5f843968acbc4e04120..78ec530a9cfd9399e1bec35fb66ff7ac7d87814d 100644 --- a/webgui/include/ajax/functions/WiSPLocationMembers.php +++ b/webgui/include/ajax/functions/WiSPLocationMembers.php @@ -9,7 +9,7 @@ function removeWiSPLocationMember($params) { $res = DBDo("UPDATE wisp_userdata SET LocationID = NULL WHERE UserID = ?",array($params[0])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/WiSPLocations.php b/webgui/include/ajax/functions/WiSPLocations.php index 07f5110e089d478647f3ef6d42f864256c3de196..6b9a29a5d2fb5c379303c8861c3305088d3196ce 100644 --- a/webgui/include/ajax/functions/WiSPLocations.php +++ b/webgui/include/ajax/functions/WiSPLocations.php @@ -76,7 +76,7 @@ function removeWiSPLocation($params) { } # Commit changes if successful - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; # Rollback database if error @@ -94,7 +94,7 @@ function createWiSPLocation($params) { $res = DBDo("INSERT INTO wisp_locations (Name) VALUES (?)",array($params[0]['Name'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -108,7 +108,7 @@ function updateWiSPLocation($params) { $res = DBDo("UPDATE wisp_locations SET Name = ? WHERE ID = ?",array($params[0]['Name'],$params[0]['ID'])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/WiSPUserTopups.php b/webgui/include/ajax/functions/WiSPUserTopups.php index 16dbb625025fb343ec985e08b18e0b723c9c4230..ea00906d48b4b43b38e52f9925e861b24f0780d4 100644 --- a/webgui/include/ajax/functions/WiSPUserTopups.php +++ b/webgui/include/ajax/functions/WiSPUserTopups.php @@ -16,7 +16,7 @@ function createWiSPUserTopup($params) { ); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -36,7 +36,7 @@ function updateWiSPUserTopup($params) { ); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } @@ -50,7 +50,7 @@ function removeWiSPUserTopup($params) { $res = DBDo("DELETE FROM topups WHERE ID = ?",array($params[0])); # Return result - if (!is_numeric($res)) { + if (is_bool($res)) { return $res; } diff --git a/webgui/include/ajax/functions/WiSPUsers.php b/webgui/include/ajax/functions/WiSPUsers.php index 91c42ca85e8c9652f555357e5a59efb5831de9f8..0276c3933dd49afaefa5147536277f1676ca1d96 100644 --- a/webgui/include/ajax/functions/WiSPUsers.php +++ b/webgui/include/ajax/functions/WiSPUsers.php @@ -230,7 +230,7 @@ function removeWiSPUser($params) { } # Commit and return if successful - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; # Else rollback database @@ -535,7 +535,7 @@ function createWiSPUser($params) { } # Commit changes if all was successful, else rollback - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; } else { @@ -582,7 +582,7 @@ function updateWiSPUser($params) { } # Commit changes if all was successful, else break - if ($res !== FALSE) { + if (is_bool($res)) { DBCommit(); return $res; } else {